Skip to content

cleaned up the code example #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

cleaned up the code example #4139

wants to merge 1 commit into from

Conversation

gondo
Copy link
Contributor

@gondo gondo commented Aug 16, 2014

  • added final return for vote() function
  • moved $user below attribute check. if attribute fails, we don't need user
  • used already declared constants in switch statement, rather than harcoded strings

@gondo
cleaned up the code example
081b3c7 
- added final return for `vote()` function
- moved `$user` below attribute check. if attribute fails, we don't need user
- used already declared constants in switch statement, rather than harcoded strings
@xabbuh
Copy link
Member

xabbuh commented Aug 17, 2014

👍 nice changes @gondo

@weaverryan
Copy link
Member

Love these - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gondo @xabbuh @weaverryan @wouterj